Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add out-of-bounds check for host side accessors #211

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Add out-of-bounds check for host side accessors #211

merged 1 commit into from
Sep 21, 2023

Conversation

GagaLP
Copy link
Contributor

@GagaLP GagaLP commented Sep 7, 2023 •
edited
Loading

This implements the out-of-bounds check for host side accessors.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Check-perf-impact results: (9e900a306dc9f17e4a27439205a7680c)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

github-actions[bot]
github-actions bot reviewed Sep 7, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

test/accessor_tests.cc Show resolved Hide resolved
test/accessor_tests.cc Show resolved Hide resolved
PeterTh
PeterTh reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@PeterTh PeterTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 2 minor remarks.

src/worker_job.cc Outdated Show resolved Hide resolved
test/accessor_tests.cc Outdated Show resolved Hide resolved
PeterTh
PeterTh approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@PeterTh PeterTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fknorr fknorr added this to the 0.5.0 milestone Sep 8, 2023
psalz
psalz requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@psalz psalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

include/accessor.h Outdated Show resolved Hide resolved
src/worker_job.cc Outdated Show resolved Hide resolved
src/worker_job.cc Outdated Show resolved Hide resolved
test/accessor_tests.cc Outdated Show resolved Hide resolved
@GagaLP GagaLP force-pushed the host_accessor branch 3 times, most recently from 4b206a9 to c1f0fb1 Compare September 12, 2023 12:10
@github-actions
Copy link

Check-perf-impact results: (7a518c63eb0655471fea6a4902fc0af7)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

github-actions[bot]
github-actions bot reviewed Sep 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/accessor.h Outdated Show resolved Hide resolved
PeterTh
PeterTh requested changes Sep 12, 2023
View reviewed changes
include/accessor.h Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Sep 12, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

include/accessor.h Show resolved Hide resolved
psalz
psalz reviewed Sep 13, 2023
View reviewed changes
include/accessor.h Outdated Show resolved Hide resolved
@GagaLP GagaLP mentioned this pull request Sep 14, 2023
Merged
psalz
psalz reviewed Sep 14, 2023
View reviewed changes
include/accessor.h Outdated Show resolved Hide resolved
psalz
psalz approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@psalz psalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fknorr
fknorr requested changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@fknorr fknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small remarks:

include/accessor.h Outdated Show resolved Hide resolved
include/accessor.h Outdated Show resolved Hide resolved
src/worker_job.cc Outdated Show resolved Hide resolved
src/worker_job.cc Outdated Show resolved Hide resolved
@github-actions
Copy link

Check-perf-impact results: (5a19ced85f862a00d0114dd241122462)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

fknorr
fknorr approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@fknorr fknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GagaLP GagaLP merged commit 41257df into master Sep 21, 2023
@fknorr fknorr deleted the host_accessor branch September 21, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@fknorr fknorr fknorr approved these changes

@PeterTh PeterTh PeterTh approved these changes

@psalz psalz psalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GagaLP @psalz @PeterTh @fknorr