Remove old workarounds; Fix build with current hipSYCL #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#preprocessor
workarounds for ComputeCppget_info
API change from enum parameters to type parameters (see [SYCL2020] Migrate information descriptors to their respective namespaces AdaptiveCpp/AdaptiveCpp#987) and removes all workarounds for older versions of hipSYCLsubscript_result_t
workaround for ComputeCpp's Clang-8 buggy implementation ofdecltype(auto)
Transitions all examples to unnamed kernels (kernel names were only required for CCPP)This allows building Celerity with the latest hipSYCL (The
latest
image is not tagged yet due to a CI bug, so 23.04 appears broken even though it passes on a manual trigger).Unfortunately the DPC++ CI is still broken due to what appears to be UB in the Intel IGC we've recently upgraded to. At some point we should bisect IGC versions to find a working revision and downgrade both our Docker environments and CI runner hosts accordingly.
Partially addresses celerity/meta#20, but some non-trivial workarounds remain that were introduced because of CCPP.