Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve command graph testing infrastructure #198

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

psalz
Copy link
Member

@psalz psalz commented Aug 1, 2023

  • Add count_per_node and assert_count[_per_node] convenience functions
  • Make have_successors more robust
  • Add documentation
  • Do a pass over existing tests to use new features and/or simplify where possible

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Check-perf-impact results: (9e900a306dc9f17e4a27439205a7680c)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

fknorr pushed a commit to fknorr/celerity-runtime that referenced this pull request Aug 23, 2023
Copy link
Contributor

@fknorr fknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm fine experimenting with these as we go along!

@fknorr fknorr added this to the 0.5.0 milestone Sep 8, 2023
@psalz psalz force-pushed the improve-cdag-testing-infrastructure branch from fab0520 to b79dc0e Compare September 11, 2023 16:17
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

test/distributed_graph_generator_test_utils.h Outdated Show resolved Hide resolved
test/graph_generation_tests.cc Outdated Show resolved Hide resolved
test/graph_generation_tests.cc Outdated Show resolved Hide resolved
test/test_utils_tests.cc Outdated Show resolved Hide resolved
- Add count_per_node and assert_count[_per_node] convenience functions
- Make have_successors more robust
- Add documentation
- Do a pass over existing tests to use new features and/or simplify
  where possible
@psalz psalz force-pushed the improve-cdag-testing-infrastructure branch from b79dc0e to 9c7cbeb Compare September 12, 2023 07:42
@psalz psalz merged commit 7a7c1ec into master Sep 12, 2023
@psalz psalz deleted the improve-cdag-testing-infrastructure branch September 12, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants