Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long-deprecated public APIs #187

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Remove long-deprecated public APIs #187

merged 2 commits into from
Jul 13, 2023

Conversation

fknorr
Copy link
Contributor

@fknorr fknorr commented Jul 11, 2023

Based on #186, so that PR must be merge first.

This removes

  • celerity::host_memory_layout (superseded by celerity::buffer_allocation_window)
  • Dims template arguments on built-in range mappers one_to_one, fixed and all (these now have generic call operators).

@fknorr fknorr requested review from psalz and BlackMark29A July 11, 2023 15:31
@fknorr fknorr self-assigned this Jul 11, 2023
github-actions[bot]

This comment was marked as outdated.

Copy link
Contributor

@PeterTh PeterTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (I obviously only reviewed the two relevant commits here)

Copy link
Member

@psalz psalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance!

@fknorr fknorr added this to the 0.4.0 milestone Jul 12, 2023
@fknorr fknorr force-pushed the remove-deprecations branch from bbeeccc to 668ace7 Compare July 13, 2023 16:02
@fknorr fknorr marked this pull request as ready for review July 13, 2023 16:02
@github-actions
Copy link

Check-perf-impact results: (9e900a306dc9f17e4a27439205a7680c)

❓ No new benchmark data submitted. ❓
Please re-run the microbenchmarks and include the results if your commit could potentially affect performance.

@psalz psalz merged commit 40a12a4 into master Jul 13, 2023
@psalz psalz deleted the remove-deprecations branch July 13, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants