Make buffer manager aware of current device memory usage #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
psalz
commented
May 30, 2023
psalz
commented
- Limit amount of device memory that can be used (currently set to 95%)
- Detect out-of-memory errors and print helpful error message listing all currently allocated buffers and their sizes
- As it turns out DPC++ (on LevelZero at least) swaps out GPU memory to system memory, and it'll just continue work (albeit slowly)
- If resizing large buffer would exceed device memory, attempt to go through host first
- If accessing part of large buffer would result in resize that exceeds device memory, attempt to spill currently unused parts to the host
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
fknorr
reviewed
Jun 1, 2023
There was a problem hiding this comment.
Some minor remarks from my side, but looks good overall.
Another naming pet-peeve of mine: I would prefer if the code explicitly talked about raw allocation sizes and alignments in terms of bytes, e.g. size_bytes, assume_bytes_freed to highlight that it doesn't refer to element counts (or some sort of allocation granularity like pages).
facuMH
reviewed
Jun 7, 2023
psalz
commented
Jun 21, 2023
psalz
force-pushed
the
bm-memory-awareness
branch
from
eb2756b to
b4548d5
Compare
- Limit amount of device memory that can be used (currently set to 95%) - Detect out-of-memory errors and print helpful error message listing all currently allocated buffers and their sizes - If resizing large buffer would exceed device memory, attempt to go through host first - If accessing part of large buffer would result in resize that exceeds device memory, attempt to spill currently unused parts to the host
psalz
force-pushed
the
bm-memory-awareness
branch
from
b4548d5 to
3838aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.