Accessor boundary check #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
psalz
requested changes
Jun 13, 2023
There was a problem hiding this comment.
Thanks, this will make life a lot easier! I've added some (mostly minor) notes; I think my biggest concern would be that the current implementation only checks against the backing buffer size, not what the user declared they plan on accessing (so whether or not the OOB check gets triggered could be dependent on scheduling decisions).
psalz
requested changes
Jun 20, 2023
PeterTh
reviewed
Jun 20, 2023
This adds a new CMake option and preprocessor macro `CELERITY_ACCESSOR_BOUNDARY_CHECK` to enable out-of-bounds checking inside accessors. The option is enabled by default in debug builds.
psalz
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #173
This check has proven quite useful when debugging, hence adding only for debug builds since it can also have a non negligible impact on performance, after all it happens for all accessor subscriptor operators.
Not sure if just reporting it as a
CELERITY_ERRORis enough or if it would also be expected for it to exit and report it as a fatal error or similar.