Disallow in-source build to prevent issues #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psalz
requested changes
Apr 25, 2023
There was a problem hiding this comment.
Thanks, good idea. Unfortunately this doesn't stop CMakeCache.txt and CMakeFiles from being created (and there doesn't seem to be a way of doing that).
Apparently there's also two built-in variables one can use to prevent in-source builds (undocumented but available since 2006). Maybe we should just use those instead?
psalz
reviewed
Apr 25, 2023
fknorr
approved these changes
Apr 30, 2023
Only check root dir and ask to delete cmake cache/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is always recommended (and a good practice) to compile in a build directory. But considering a celerity user could potentially not be familiarized with good programming/debugging practices, this check should save them some time of headache.