Lift restrictions on reductions for DPC++ #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fknorr
requested changes
Apr 14, 2023
There was a problem hiding this comment.
Nice! This means we can test full reduction support in CI for the first time.
We should however keep all feature flags intact (CELERITY_FEATURE_SIMPLE_SCALAR_REDUCTIONS, CELERITY_FEATURE_SCALAR_REDUCTIONS, CELERITY_FEATURE_LOCAL_ACCESSOR) since they part of the user-facing API (both CMake variables and compile_definitions).
psalz
force-pushed
the
lift-dpcpp-reduction-restrictions
branch
2 times, most recently
from
fc4b91e to
fb7c0ff
Compare
|
Done! |
fknorr
reviewed
Apr 17, 2023
psalz
force-pushed
the
lift-dpcpp-reduction-restrictions
branch
from
fb7c0ff to
7445ba8
Compare
DPC++ now supports passing multiple reductions into a kernel. The restriction on 1-dimensional buffers can also be lifted as we now use pointer-based reductions internally.
psalz
force-pushed
the
lift-dpcpp-reduction-restrictions
branch
from
7445ba8 to
f7ce69c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPC++ now supports passing multiple reductions into a kernel. While it still only accepts 1-dimensional buffers (I guess the spec is simply ambiguous on this), that no longer matters to us since we now do a pointer-based reduction internally anyway.