Add an option to use the mimalloc memory allocator #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Off-topic, but since you are already drive-by-ing some stuff and are touching the main cmake file, can you also drive-by fix the |
|
We've had an offline discussion regarding the bump in CMake min version. I'll look into whether we can link dynamically to avoid that, and what the perf impact (if any) is. |
PeterTh
force-pushed
the
mimalloc
branch
2 times, most recently
from
d96d6cc to
2f67f13
Compare
|
The PR has been modified to use mimalloc as a shared library. This has two consequences:
Benchmarks are slightly different (both in positive and negative direction), but the overall picture and advantage compared to the default allocator remains the same. |
fknorr
approved these changes
Mar 30, 2023
mimalloc is included as a submodule. Also add a few common entries to gitignore, and enable compile_commands generation by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mimalloc is included as a submodule, used with
FetchContent(as per convention).Increases the required CMake version to 3.21 to enable$<TARGET_OBJECTS:.MiMalloc generally seems to improve overall performance in the more realistic/larger microbenchmark scenarios by ~30% compared to the default allocator on GPUC2, which is quite significant for a simple allocator change:
It does not decrease performance in any microbenchmark (log-y):
Drive-by:
compile_commands.jsongeneration by default (we have discussed that we should do this in several F2F meetings before)