Bump minimum required SYCL versions, drop support for ComputeCpp #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fknorr
approved these changes
Mar 24, 2023
Due to its, as of version 2.11, flaky support for USM, we cannot support ComputeCpp for the time being.
This is in preparation for transitioning to native device pointers for backing buffer allocations. The new revisions are known to work with the patch, but have not been selected for any particular commit (= earlier revisions may also work).
psalz
force-pushed
the
ci-bump-sycl-versions
branch
from
f07289c to
2d7218f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the minimum required versions for hipSYCL and DPC++ in anticipation of #162. Additionally, we have to drop support for ComputeCpp for the time being, as its USM support can be described as flaky at best, and working around all the encountered issues (if at all possible) is simply not worth the effort.