Add libenvpp #158
Add libenvpp #158
Conversation
There was a problem hiding this comment.
Already looks much better than before, but there are still some issues.
One of them is that there are no unit tests to make sure environment variable parsing works as expected. To this end libenvpp supports the set_for_testing function on the prefix, which can be used in unit tests to specify which value a certain variable should have.
Further issues are:
facuMH
force-pushed
the
integration/libenvpp
branch
5 times, most recently
from
29d4c64 to
99b8e58
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
facuMH
force-pushed
the
integration/libenvpp
branch
from
be38542 to
2d9e9eb
Compare
There was a problem hiding this comment.
Looks good to me now.
However, before merging this, the libenvpp dependency should not be on something in the development branch, but rather the official release of version 1.1.0. I will wait with the release of that version until other people have also reviewed this PR, so that if further libenvpp features are required I can add them to version 1.1.0 without having to do another release.
facuMH
force-pushed
the
integration/libenvpp
branch
from
30b1deb to
cecd852
Compare
facuMH
force-pushed
the
integration/libenvpp
branch
from
cecd852 to
7486e90
Compare
facuMH
force-pushed
the
integration/libenvpp
branch
from
7486e90 to
8dc777d
Compare
|
I released v1.1.0 of libenvpp. So this PR can be updated to use the official release and then be merged. |
facuMH
force-pushed
the
integration/libenvpp
branch
from
7faf84b to
c81e456
Compare
Test config properly parses correct env vars or reports when they can not be parsed. Add test for deprecated env vars. libenvpp checked out at v1.1 tag.
facuMH
force-pushed
the
integration/libenvpp
branch
from
c81e456 to
bb3db10
Compare
For multiple runtime parameters celerity uses environment variables.
This library makes the fetching of these variables easier while providing suggestions if miss spelling some of them.
It is also OS independent, hence we do not have to worry about OS specifics for fetching the env vars.
This PR depends on #155