Fix race between creating collective groups and submitting host tasks #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Celerity has a race condition on worker nodes between submission of collective host tasks and the submission of their kernels to the host queue. Choosing a non-default collective group creates an additional worker thread from the main thread, and kernel submission requires that thread to be up and running.
host_queue
was accessed by both main and executor thread, it was left unsynchronized. The class member is now protected by a mutex.