Communicate buffer creation to graph generator through scheduler event #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
BlackMark29A
approved these changes
Aug 29, 2022
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the graph generator holds a
m_buffer_mutexfor the sole purpose of synchronizing buffer addition between main thread and scheduler thread. This is contrary to the otherwise thread-unaware design of the graph generator and could cause scheduler stalls if buffers are constructed while tasks are scheduled.This PR introduces a new scheduler event for buffer addition which makes this mutex unnecessary. It also transfers ownership of graph generator and graph serializer to the scheduler in order to prevent accidental concurrent access from a non-scheduler thread.
test_utils::mock_buffer_factoryalso gets a richer constructor interface to be able to deal with either a non-threaded graph generator or a threaded scheduler.