Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove task mutex #137

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Remove task mutex #137

merged 2 commits into from
Aug 30, 2022

Conversation

fknorr
Copy link
Contributor

@fknorr fknorr commented Aug 25, 2022

task_manager had a m_task_mutex left over from #112 that is now superfluous.

It was used in five places, all of which are only ever called from the main thread:

  • task_manager::submit_command_group()
  • task_manager::add_buffer()
  • task_manager::generate_epoch_task()
  • task_manager::generate_horizon_task()
  • task_manager::print_graph()

All concurrency the task manager is involved in now is handled by the epoch monitor.

@fknorr fknorr requested review from psalz and PeterTh August 25, 2022 14:01
@fknorr fknorr self-assigned this Aug 25, 2022
include/task_manager.h Show resolved Hide resolved
src/task_manager.cc Show resolved Hide resolved
@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@fknorr fknorr requested a review from PeterTh August 29, 2022 08:24
Copy link
Contributor

@PeterTh PeterTh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fknorr fknorr force-pushed the remove-task-mutex branch from deae704 to 8c0d234 Compare August 29, 2022 15:09
@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@fknorr fknorr merged commit b0254fd into master Aug 30, 2022
@fknorr fknorr deleted the remove-task-mutex branch August 30, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants