-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove abstract_command::debug_label #133
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that there are formatting changes but no changes to any test, I assume we don't have any. Maybe it would be good to add at least a simple basic graph printing unit test (ideally in a commit before the change).
clang-tidy review says "All clean, LGTM! 👍" |
1c4deb9
to
1315274
Compare
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! The graphs look much nicer now.
In addition to the missing separation of concerns, this is surprisingly slow as it uses iostreams to print the GridRegion of each requirement.
Have you tried running the microbenchmarks to see whether this is measurable?
clang-tidy review says "All clean, LGTM! 👍" |
c0ff88b
to
ea7b6f3
Compare
ea7b6f3
to
e8845f2
Compare
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
LGTM. Re:16 threads - my guess would be that the improvement from getting rid of this string processing only scales linearly with the number of nodes, while many other overheads scale non-linearly, so the relative impact is reduced at increasing node counts. |
Currently, the DOT graph generation for
print_graph
happens partially ingraph_generator
, which stringifies the data requirements into theabstract_command::debug_label
. In addition to the missing separation of concerns, this is surprisingly slow as it uses iostreams to print theGridRegion
of each requirement.This PR moves this entire printing logic to
print_graph.cc
and removes thedebug_label
member. It also simplifies the remaining printing code by replacing iostreams uses with fmt.The CI failure on
dpcpp:HEAD
is due to a bug in Clang 15 and not related to this PR.