Fix compilation and runtime issues on windows #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
fknorr
approved these changes
Aug 2, 2022
BlackMark29A
force-pushed
the
windows-fixes
branch
from
d188690 to
395b2d7
Compare
BlackMark29A
force-pushed
the
windows-fixes
branch
from
395b2d7 to
6c7d85b
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #129, so that one must be merged first.
Some code changes in past PRs have introduced code that no longer compiles on windows, this PR remedies that by adding missing headers and some minor code tweaks.
Additionally, PR #106 refactored the unit tests, specifically changing when
MPI_Initis called relative to when Catch2 is initialized. This surfaced an issue where MSMPI changes the top-level exception filter, after Catch2 has already changed it, resulting in a sanity check inside Catch2 failing, where it checks that the previous filter was restored correctly. This PR disables windows SEH for Catch2, mitigating the issue.