Avoid unnecessary allocations around buffer storage #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various
get_data
andset_data
functions on buffer storage objects take and return data inraw_buffer_storage
instances. While this is good for memory safety in APIs, it forces unnecessary copies when that data is taken from or written into larger data structures as happens in #94 and #114.This PR replaces
raw_buffer_storage
with raw pointers for those APIs. Where ownership is required, the new type-erasing smart pointer typeunique_payload_ptr
is used which either manages an ad-hoc allocation (likeraw_buffer_storage
without the metadata) or takes ownership of aunique_frame_ptr
, but points to its payload.