Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all_tests unit test executable, linking all unit test object files #104

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

PeterTh
Copy link
Contributor

@PeterTh PeterTh commented Mar 9, 2022

Build system and CI only change, builds all tests as CMake "Object libraries" and links them together as required.

@PeterTh PeterTh requested a review from fknorr March 9, 2022 13:03
@PeterTh PeterTh self-assigned this Mar 9, 2022
@PeterTh PeterTh force-pushed the unit-test-all-target branch from 21d2f1e to 56ac6f8 Compare March 10, 2022 13:17
Copy link
Member

@psalz psalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterTh
Copy link
Contributor Author

PeterTh commented Mar 10, 2022

All of the CI runs got faster with this -- I looked into the logs and all assertions which should run seem to run.
It seems like half the reason is less startup/shutdown overhead for individual unit tests, and half is not running the benchmarks as part of the CI tests (I made a separate draft issue for that).

@PeterTh PeterTh force-pushed the unit-test-all-target branch from 56ac6f8 to 298684f Compare March 10, 2022 15:06
bash /root/capture-backtrace.sh "$test"
done
# We just call the all_tests executable manually to get around this.
bash /root/capture-backtrace.sh test/all_tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way less hacky, I like it!

@PeterTh PeterTh merged commit c12b052 into master Mar 10, 2022
@psalz psalz deleted the unit-test-all-target branch March 10, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants