Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test maintenance & refactoring #102

Merged
merged 3 commits into from
Mar 7, 2022
Merged

Conversation

PeterTh
Copy link
Contributor

@PeterTh PeterTh commented Mar 4, 2022

This only touches unit tests, but does all the following:

  • upgrade Catch2 to v3, and use individual headers
  • semantically restructure unit tests to more translation units
  • eliminate some code duplication
  • improve naming & tagging of a few units test

I verified that the number of assertions executed on master and unit-test-mainenance is the same.

Full rebuild times (s) [gpuc1]:

Type master This PR
Debug 65.992 51.792
Release 183.796 105.901

Obviously, partial rebuilds of affected TUs benefit even more.

Copy link

@BlackMark29A BlackMark29A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@PeterTh PeterTh force-pushed the unit-test-maintenance branch from dfe81d0 to aa989b2 Compare March 7, 2022 14:43
@PeterTh PeterTh merged commit ba35936 into master Mar 7, 2022
@psalz psalz deleted the unit-test-maintenance branch March 8, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants