WPF - Experimental LifeSpanHandler optional LifespanHandler construct…

…or arg Resolves #4285
cefsharp · Nov 14, 2022 · 824ba98 · 824ba98
1 parent 3866af0
commit 824ba98
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/CefSharp.Wpf.Example/Views/BrowserTabView.xaml.cs b/CefSharp.Wpf.Example/Views/BrowserTabView.xaml.cs
@@ -170,15 +170,12 @@ public BrowserTabView()
                     //If browser is disposed then we don't need to remove the tab
                     if (!ctrl.IsDisposed)
                     {
-                        ctrl.Dispatcher.Invoke(() =>
-                        {
-                            var owner = System.Windows.Window.GetWindow(ctrl);
+                        var owner = System.Windows.Window.GetWindow(ctrl);
 
-                            if (owner != null && owner.Content == ctrl)
-                            {
-                                owner.Close();
-                            }
-                        });
+                        if (owner != null && owner.Content == ctrl)
+                        {
+                            owner.Close();
+                        }
                     }
                 }).Build();
             */

diff --git a/CefSharp.Wpf/Experimental/LifespanHandler.cs b/CefSharp.Wpf/Experimental/LifespanHandler.cs
@@ -73,7 +73,11 @@ public class LifeSpanHandler : CefSharp.Handler.LifeSpanHandler
         private Dictionary<IntPtr, ChromiumWebBrowser> chromiumWebBrowserMap = new Dictionary<IntPtr, ChromiumWebBrowser>();
         private ChromiumWebBrowser pendingChromiumWebBrowser;
 
-        public LifeSpanHandler(LifeSpanHandlerCreatePopupChromiumWebBrowser chromiumWebBrowserCreatedDelegate)
+        /// <summary>
+        /// Default constructor
+        /// </summary>
+        /// <param name="chromiumWebBrowserCreatedDelegate">optional delegate to create a custom <see cref="ChromiumWebBrowser" instance./></param>
+        public LifeSpanHandler(LifeSpanHandlerCreatePopupChromiumWebBrowser chromiumWebBrowserCreatedDelegate = null)
         {
             this.chromiumWebBrowserCreatedDelegate = chromiumWebBrowserCreatedDelegate;
         }