Support multiple readers in the mapping-template component #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioscrock
requested changes
Jul 26, 2024
| @@ -148,36 +144,46 @@ else if ((params.resourceCustomFunctions() == null) && (params.customFunctions ! | |||
| formatter = Util.createFormatter(params.formatterFormat()); | |||
| } | |||
|
|
|||
| TemplateExecutor templateExecutor; | |||
There was a problem hiding this comment.
Move TemplateExecutor as a field of the class MaptTemplateProducer to reuse the same instance across multiple executions of the same route
marioscrock
requested changes
Sep 25, 2024
camel-chimera-mapping-template/src/main/java/com/cefriel/rdf/MaptTemplateProcessor.java
Outdated
Show resolved
Hide resolved
camel-chimera-mapping-template/src/main/java/com/cefriel/rdf/MaptTemplateProcessor.java
Show resolved
Hide resolved
marioscrock
requested changes
Oct 1, 2024
| exchange.getMessage().setBody(resultFilePath, String.class); | ||
| } | ||
| } | ||
| // if filename is not specified then the result of applying template is stored in the exchange body as string | ||
| else { | ||
| if (params.query() != null) { | ||
| Map<String,String> result = templateExecutor.executeMappingParametric(reader, ResourceAccessor.open(params.template(), exchange), ResourceAccessor.open(params.query(), exchange), templateMap, formatter, usedTemplateFunctions); | ||
| Map<String,String> result; | ||
| if (reader != null) { |
There was a problem hiding this comment.
Here and in other invocations to the mapping-template, avoid repeated code blocks. Change as:
Map<String, Reader> readers; //Check where defined and if we need to define it again
if (reader != null)
readers = Map.of("reader", reader);
result = templateExecutor.executeMappingParametric(readers,
ResourceAccessor.open(params.template(), exchange),
ResourceAccessor.open(params.query(), exchange));| exchange.getMessage().setBody(result, Map.class); | ||
|
|
||
| } else { | ||
| String result = templateExecutor.executeMapping(reader, ResourceAccessor.open(params.template(), exchange), templateMap, formatter, usedTemplateFunctions); | ||
| String result; | ||
| if (reader != null) { |
There was a problem hiding this comment.
Ideally, define readers map at the beginning and then perform calls without checking reader every time
hamzabhatti5253
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an endpoint to the mapping template component "mapt://readers?..." that expects as input an exchange whose body contains a
Map<String,Reader>ofReaders.If accepted, it should be merged only after cefriel/mapping-template#27.