Skip to content

Commit

Permalink
Update new nav categories to add Enterprise Search + update plugin to…
Browse files Browse the repository at this point in the history
… use new category

- per @johnbarrierwilson and Matt Riley, Enterprise Search should be under Kibana and above Observability
  • Loading branch information
cee-chen committed May 7, 2020
1 parent 93d71be commit 0cca6c6
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
12 changes: 10 additions & 2 deletions src/core/utils/default_app_categories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,20 +29,28 @@ export const DEFAULT_APP_CATEGORIES = Object.freeze({
euiIconType: 'logoKibana',
order: 1000,
},
enterpriseSearch: {
id: 'enterpriseSearch',
label: i18n.translate('core.ui.enterpriseSearchNavList.label', {
defaultMessage: 'Enterprise Search',
}),
order: 2000,
euiIconType: 'logoEnterpriseSearch',
},
observability: {
id: 'observability',
label: i18n.translate('core.ui.observabilityNavList.label', {
defaultMessage: 'Observability',
}),
euiIconType: 'logoObservability',
order: 2000,
order: 3000,
},
security: {
id: 'security',
label: i18n.translate('core.ui.securityNavList.label', {
defaultMessage: 'Security',
}),
order: 3000,
order: 4000,
euiIconType: 'logoSecurity',
},
management: {
Expand Down
4 changes: 1 addition & 3 deletions x-pack/plugins/enterprise_search/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ export class EnterpriseSearchPlugin implements Plugin {
core.application.register({
id: 'enterprise_search',
title: 'App Search', // TODO: This will eventually be 'Enterprise Search' once there's more than just App Search in here
euiIconType: AppSearchLogo, // TODO: Temporary - App Search will likely no longer need an icon once the nav structure changes.
category: DEFAULT_APP_CATEGORIES.management, // TODO - This is likely not final/correct
order: 10, // TODO - This will also likely not be needed once new nav structure changes land
category: DEFAULT_APP_CATEGORIES.enterpriseSearch,
mount: async (params: AppMountParameters) => {
const [coreStart] = await core.getStartServices();

Expand Down

0 comments on commit 0cca6c6

Please sign in to comment.