Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the code #1

Open
cedrusx opened this issue Mar 10, 2016 · 0 comments
Open

Refactor the code #1

cedrusx opened this issue Mar 10, 2016 · 0 comments

Comments

@cedrusx
Copy link
Owner

cedrusx commented Mar 10, 2016

  1. Encapsulate rules
  2. Make the calculating classes data-oriented
cedrusx added a commit that referenced this issue Mar 10, 2016
@cedrusx
Let SmartCalc be subclass of RuleParser, #1
af8f6f6
cedrusx added a commit that referenced this issue Mar 10, 2016
@cedrusx
Add a draft of rule classes, #1
a0bfcb9
cedrusx added a commit that referenced this issue Mar 12, 2016
@cedrusx
Make classes for rules #1
25903f8 
Define methods & usage of rule classes.
Rewrite RuleParser::parse to use the rule classes.
Change tabs to spaces.

Signed-off-by: cedrusx <shixuesong@gmail.com>
cedrusx added a commit that referenced this issue Mar 16, 2016
@cedrusx
Encapsulate rules and constraints, #1
f31957d 
Hide the complexity of rule-specific operations.
In order to make main.py conciser and make it easier
to support new rules in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cedrusx