Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests against main ruby 3.4 release #455

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

santiagorodriguez96
Copy link
Contributor

No description provided.

@nicolastemciuc
Copy link
Member

What do you think about running rubocop using Ruby 3.4?

lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
bundler-cache: true
- run: bundle exec rubocop -f github

@santiagorodriguez96
Copy link
Contributor Author

What do you think about running rubocop using Ruby 3.4?

lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
bundler-cache: true
- run: bundle exec rubocop -f github

Good call! Will open a different PR for that 🙂

@santiagorodriguez96 santiagorodriguez96 merged commit 797e8a6 into master Feb 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants