Allow to pass expected origin to verify #365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manubo
commented
Aug 4, 2022
Comment on lines
-177
to
+209
| expect(public_key_credential.client_extension_outputs) | ||
| .to eq({ "txAuthSimple" => "Could you please verify yourself?" }) | ||
| expect( | ||
| public_key_credential.client_extension_outputs | ||
| ).to eq({ "txAuthSimple" => "Could you please verify yourself?" }) |
Comment on lines
-231
to
+264
| expect(public_key_credential.authenticator_extension_outputs) | ||
| .to eq({ "txAuthSimple" => "Could you please verify yourself?" }) | ||
| expect( | ||
| public_key_credential.authenticator_extension_outputs | ||
| ).to eq({ "txAuthSimple" => "Could you please verify yourself?" }) |
|
Hi @brauliomartinezlm, thanks for your feedback. I have seen that #368 was merged, which is great. There is no v3 alpha2 tag yet, but I assume it's the same as master at the moment, right? I will give it a try, thanks for your support 👍🏼 |
|
Closed in favour of using v3 of this gem. |
|
@manubo I've just released 3.0.0.alpha2. Hope it worked as you needed. |
|
Yes, works like a charm, thanks @brauliomartinezlm 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
WebAuthn::AuthenticatorAttestationResponse#verifyandWebAuthn::AuthenticatorAssertionResponse#verifyaccept the parameter
expected_origin, but the calling methodsPublicKeyCredentialWithAttestation#verifyandPublicKeyCredentialWithAssertion#verify,respectively, do not.
We have a multi-tenant system where each tenant has its own subdomain and need to be able to pass the origin when validating the data.