Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing expected origin to credential verify #345

Closed
wants to merge 1 commit into from
Closed

feat: allow passing expected origin to credential verify #345

wants to merge 1 commit into from

Conversation

nrw505
Copy link

@nrw505 nrw505 commented Jun 7, 2021

If you have an app that serves from multiple domain names, you need to
be able to pass the expected origin to the verify method of
PublicKeyCredentialWithAssertion and PublicKeyCredentialWithAttestation

If you have an app that serves from multiple domain names, you need to
be able to pass the expected origin to the `verify` method of
PublicKeyCredentialWithAssertion and PublicKeyCredentialWithAttestation
@brauliomartinezlm
Copy link
Member

brauliomartinezlm commented Jun 7, 2021

Hi @nrw505 ,

Thank you for your PR ❤️
The gem currently provides a way to handle multi-tenant applications the following way. There has been a few issues reported on that matter that we have now luckily closed, but might be useful to browse through them to find similarities with what you're going though. We have moved away voluntarily from passing the expected origin, rp_id and others directly to the verification methods.

BTW, the docs I pointed to were not merged when you saw the README and I apologized for my lateness on that on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants