RangeSet: support negative ranges (#515) #518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support negative ranges in RangeSet, with as little impact as possible to the normal (positive range) codepath. Zero padding is not available with negative ranges at this time for this reason.
In case of negative ranges, RangeSet will case the numbers to integer. Internal sorting then looks like this (eg. -5-6):
['-5', '-4', '-3', '-2', '-1', '0', '1', '2', '3', '4', '5', '6']
Apart from the internal sorting change, little modifications are needed in the parser and the folding method, so I guess it's worth it.
Usage examples:
Hence, the following is now possible:
$ cluset -f foo[-10-10]
foo[-10-10]
$ cluset -f foo[-100--90/2]
foo[-100,-98,-96,-94,-92,-90]
Closes #515.