Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/refactor create notification status #2296

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Task/refactor create notification status #2296

merged 4 commits into from
Sep 23, 2024

Conversation

jzbahrai
Copy link
Collaborator

Summary | Résumé

Just refactoring the reporting task (I haven't changed the tests or anything as the code remains the same).

What I have done:

  1. Don't hold all service ids in memory - chunk them
  2. Fetch data from the DB in chunks
  3. commit data once it is fetched in chunks.

andrewleith
andrewleith approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@andrewleith andrewleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzbahrai jzbahrai merged commit 96b39cd into main Sep 23, 2024
4 checks passed
@jzbahrai jzbahrai deleted the task/refactor-create-notification-status branch September 23, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewleith andrewleith andrewleith approved these changes

@whabanks whabanks Awaiting requested review from whabanks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzbahrai @andrewleith