Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Update Terraform AWS Provider to v3.2.0 or higher #262

Closed
CalvinRodo opened this issue Aug 24, 2020 · 0 comments · Fixed by cds-snc/covid-alert-server-staging-terraform#44
Assignees
Labels

Comments

@CalvinRodo
Copy link
Member

There is a bug in the current version that forces a rebuild of the WAF if we change the WAF rules.

hashicorp/terraform-provider-aws#14616

@CalvinRodo CalvinRodo added bug Something isn't working infrastructure labels Aug 24, 2020
@CalvinRodo CalvinRodo self-assigned this Oct 19, 2020
@CalvinRodo CalvinRodo changed the title Update Terraform AWS Provider to v3.20 or higher Update Terraform AWS Provider to v3.2.0 or higher Oct 19, 2020
CalvinRodo added a commit to cds-snc/covid-alert-server-staging-terraform that referenced this issue Oct 20, 2020
Pin the Terraform Version to greater then v0.13.4 (The version I'm
running on my machine - Cal)
Pin the AWS Provider to 3.11 or greater which is the current version of
the provider.

Due to how ACM validation works in the new version of the provider we
had to modify that resource so it no longer access the first item in the
Domain_Validation_Options property but iterates through all
possibilities.

This means there will be a new ACM Validation Resource created for
wild-samphire.cdssandbox.xyz alongside the Validation Resource for
*.wild-samphire.cdssandbox.xyz.

In order to prevent the application of these state files from deleting
and creating the existing ACM Validation Resources I had to manually run
the following two commands:

```bash
terraform state mv 'aws_route53_record.covidshield_certificate_validation' 'aws_route53_record.covidshield_certificate_validation["*.wild-samphire.cdssandbox.xyz"]'
terraform state mv 'aws_route53_record.retrieval_covidshield_certificate_validation' 'aws_route53_record.retrieval_covidshield_certificate_validation["retrieval.wild-samphire.cdssandbox.xyz"]'
```

*Please Note:* These should be the same commands in all environments
(with different URI's) but you should double check by running `terraform
plan` locally and viewing what resources will be created and destroyed
and work from there.

This closes #41 and also closes cds-snc/covid-alert-server#262
CalvinRodo added a commit to cds-snc/covid-alert-server-staging-terraform that referenced this issue Oct 20, 2020
* feat: Upgrading to tf 0.12 interpolation

* feat: Upgrade AWS Provider and Terraform Version

Pin the Terraform Version to greater then v0.13.4 (The version I'm
running on my machine - Cal)
Pin the AWS Provider to 3.11 or greater which is the current version of
the provider.

Due to how ACM validation works in the new version of the provider we
had to modify that resource so it no longer access the first item in the
Domain_Validation_Options property but iterates through all
possibilities.

This means there will be a new ACM Validation Resource created for
wild-samphire.cdssandbox.xyz alongside the Validation Resource for
*.wild-samphire.cdssandbox.xyz.

In order to prevent the application of these state files from deleting
and creating the existing ACM Validation Resources I had to manually run
the following two commands:

```bash
terraform state mv 'aws_route53_record.covidshield_certificate_validation' 'aws_route53_record.covidshield_certificate_validation["*.wild-samphire.cdssandbox.xyz"]'
terraform state mv 'aws_route53_record.retrieval_covidshield_certificate_validation' 'aws_route53_record.retrieval_covidshield_certificate_validation["retrieval.wild-samphire.cdssandbox.xyz"]'
```

*Please Note:* These should be the same commands in all environments
(with different URI's) but you should double check by running `terraform
plan` locally and viewing what resources will be created and destroyed
and work from there.

This closes #41 and also closes cds-snc/covid-alert-server#262

* fix: Pin to specific TF Version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants