Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: update ruff #172

Merged
merged 2 commits into from
Sep 10, 2024
Merged

maint: update ruff #172

merged 2 commits into from
Sep 10, 2024

Conversation

ManonMarchand
Copy link
Member

@ManonMarchand ManonMarchand commented Sep 10, 2024 •
edited
Loading

Update ruff.
It had two new set of rules interesting for us:

  • NPY: points to thing that will be removed in numpy 2.0 (here we mosty had uses of the old random number generator API, was straightforward to fix)
  • PYT: pytest style rules, small fixes too

I also switched to the ruff formatter instead of black which removes two dependencies in our pre-commit hooks: black and nbqa

@ManonMarchand
maint: add pytest and numpy ruff rules
88766df 
this helps prepare the support of numpy 2.0
@ManonMarchand
maint: use ruff format instead of black
515b3c8 
less dependencies on exterior hooks (removed black and nbqa that we used to run black on notebooks)
@ManonMarchand ManonMarchand changed the title Maint update ruff maint: update ruff Sep 10, 2024
@ManonMarchand ManonMarchand merged commit 02ad85d into master Sep 10, 2024
14 checks passed
@ManonMarchand ManonMarchand deleted the maint-update-ruff branch September 10, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ManonMarchand