Merge pull request #120 from cds-astro/add-EllipticalFrame-to-some-ex…

…amples Add elliptical frame to most examples with allsky plots
cds-astro · Dec 4, 2023 · 1facb81 · 1facb81
2 parents 364618d + 43a44f8
commit 1facb81
Show file tree

Hide file tree

Showing 12 changed files with 610 additions and 84,170 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -18,13 +18,13 @@ repos:
     - id: black
   # Fast linter to replace flake8
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: 'v0.1.5'
+    rev: 'v0.1.6'
     hooks:
      - id: ruff
        fail_fast: true
   # Same tools but for Jupyter notebooks
   - repo: https://github.com/nbQA-dev/nbQA
-    rev: 1.7.0
+    rev: 1.7.1
     hooks:
       - id: nbqa-black
         name: nbqa-black

diff --git a/docs/examples/polygon_coverage.py b/docs/examples/polygon_coverage.py
@@ -2,7 +2,6 @@
 import matplotlib.pyplot as plt
 import numpy as np
 from astropy.coordinates import Angle, SkyCoord
-
 from mocpy import MOC, WCS
 
 # The set of points delimiting the polygon in deg
@@ -34,7 +33,7 @@
 # A point that we say it belongs to the inside of the MOC
 inside = SkyCoord(ra=10, dec=5, unit="deg", frame="icrs")
 moc = MOC.from_polygon_skycoord(skycoord, max_depth=9)
-moc.write("polygon_moc.fits", format="fits", overwrite=True)
+moc.save("polygon_moc.fits", format="fits", overwrite=True)
 
 # Plot the MOC using matplotlib
 fig = plt.figure(111, figsize=(10, 10))

diff --git a/notebooks/00-MOCpy_introduction.ipynb b/notebooks/00-MOCpy_introduction.ipynb
diff --git a/notebooks/FITS-image-pixels-intersecting-MOC.ipynb b/notebooks/FITS-image-pixels-intersecting-MOC.ipynb
@@ -13,13 +13,13 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "from astropy.io import fits\n",
-    "from astropy.wcs import WCS as WCS\n",
-    "from mocpy import MOC\n",
-    "from astropy.visualization import simple_norm\n",
     "import astropy.units as u\n",
+    "import matplotlib.pyplot as plt\n",
     "import numpy as np\n",
-    "import matplotlib.pyplot as plt"
+    "from astropy.io import fits\n",
+    "from astropy.visualization import simple_norm\n",
+    "from astropy.wcs import WCS\n",
+    "from mocpy import MOC"
    ]
   },
   {
@@ -206,7 +206,7 @@
  ],
  "metadata": {
   "kernelspec": {
-   "display_name": "Python 3.8.10 64-bit",
+   "display_name": "Python 3 (ipykernel)",
    "language": "python",
    "name": "python3"
   },
@@ -220,7 +220,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.11.2"
+   "version": "3.12.0"
   },
   "toc": {
    "base_numbering": 1,
@@ -239,8 +239,15 @@
    "interpreter": {
     "hash": "916dbcbb3f70747c44a77c7bcd40155683ae19c65e1c03b4aa3499c5328201f1"
    }
+  },
+  "widgets": {
+   "application/vnd.jupyter.widget-state+json": {
+    "state": {},
+    "version_major": 2,
+    "version_minor": 0
+   }
   }
  },
  "nbformat": 4,
- "nbformat_minor": 2
+ "nbformat_minor": 4
 }
diff --git a/notebooks/First_Steps_with_FMOCs.ipynb b/notebooks/First_Steps_with_FMOCs.ipynb
@@ -443,7 +443,7 @@
     "# but we can change it to linear if needed\n",
     "ax.set(xscale=\"linear\")\n",
     "# and any customization on the ax of fig objects will work too\n",
-    "ax.spines[[\"left\", \"top\", \"right\"]].set_visible(False)  # noqa: FBT003"
+    "ax.spines[[\"left\", \"top\", \"right\"]].set_visible(False)"
    ]
   },
   {
@@ -563,7 +563,7 @@
  ],
  "metadata": {
   "kernelspec": {
-   "display_name": "mocpy-tests",
+   "display_name": "Python 3 (ipykernel)",
    "language": "python",
    "name": "python3"
   },
@@ -578,6 +578,13 @@
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
    "version": "3.11.2"
+  },
+  "widgets": {
+   "application/vnd.jupyter.widget-state+json": {
+    "state": {},
+    "version_major": 2,
+    "version_minor": 0
+   }
   }
  },
  "nbformat": 4,

diff --git a/notebooks/STMOC from time ranges.ipynb b/notebooks/STMOC from time ranges.ipynb
diff --git a/notebooks/compute_moc_borders.ipynb b/notebooks/compute_moc_borders.ipynb
diff --git a/notebooks/filtering_astropy_table.ipynb b/notebooks/filtering_astropy_table.ipynb
diff --git a/notebooks/from_astropy_table.ipynb b/notebooks/from_astropy_table.ipynb
diff --git a/notebooks/from_fits_and_intersection.ipynb b/notebooks/from_fits_and_intersection.ipynb
diff --git a/notebooks/from_polygon.ipynb b/notebooks/from_polygon.ipynb
diff --git a/pyproject.toml b/pyproject.toml
@@ -88,9 +88,10 @@ locked = false
 "python/mocpy/moc/plot/wcs.py" = ["B008"]
 "python/mocpy/tests/*.py" = ["S101", "D103"] # S101: use of "assert" detected
 "python/mocpy/serializer.py" = ["A002"] # Argument "format" is shadowing a python builtin
+"notebooks/*.ipynb" = ["T201"] # print is okish in notebooks
 
 [tool.nbqa.addopts]
-ruff = ["--ignore=B018,FBT003"]
+ruff = ["--ignore=B018,FBT003,T201"]
 
 [tool.ruff]
 fix = true