fix: reset unsaved controls changes on modal close

cdrani · Sep 26, 2024 · 34e5053 · 34e5053
1 parent 04919cb
commit 34e5053
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/src/events/listeners/header-listeners.js b/src/events/listeners/header-listeners.js
@@ -13,8 +13,10 @@ export default class HeaderListeners extends Listeners {
 
     init() {
         if (this._setup) {
+            this._viewInFocus == 'seek' && this._seek.init()
             this._viewInFocus == 'fx' && this._reverb.init()
             this._viewInFocus == 'eq' && this._equalizer.init()
+            this._viewInFocus == 'speed' && this._speed.init()
             return
         }
 
@@ -29,7 +31,19 @@ export default class HeaderListeners extends Listeners {
         this._setup = true
     }
 
+    #clearReverb() {
+        const reverb = this._store.getReverb() || 'none'
+        if (reverb == 'none') this._reverb.clearReverb()
+    }
+
+    #clearEqualizer() {
+        const equalizer = this._store.getEqualizer() || 'none'
+        if (equalizer == 'none') this._equalizer.clearEqualizer()
+    }
+
     async hide() {
+        if (this._viewInFocus == 'fx') this.#clearReverb()
+        if (this._viewInFocus == 'eq') this.#clearEqualizer()
         if (this._viewInFocus == 'speed') this._speed.clearCurrentSpeed()
         this._hide()
     }

diff --git a/src/events/listeners/listeners.js b/src/events/listeners/listeners.js
@@ -1,3 +1,4 @@
+import { store } from '../../stores/data.js'
 import Seek from '../../models/seek/seek.js'
 import Speed from '../../models/speed/speed.js'
 import { spotifyVideo } from '../../actions/overload.js'
@@ -7,6 +8,7 @@ import EqualizerController from '../../models/equalizer/equalizer-controller.js'
 
 export default class Listeners {
     constructor(songTracker) {
+        this._store = store
         this._video = spotifyVideo.element
         this._seek = new Seek()
         this._speed = new Speed()

diff --git a/src/models/reverb/reverb-controller.js b/src/models/reverb/reverb-controller.js
@@ -99,7 +99,7 @@ export default class ReverbController {
         const { roomEffect, convolverEffect, presetSelection } = this.elements
 
         if (effect == 'none') {
-            this.setValuesToNone()
+            this.clearReverb()
         } else {
             presetSelection.textContent = effect
             const selectedElement = roomPresets.includes(effect) ? roomEffect : convolverEffect