feat: automate upgrading Terraform #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiehan
requested review from
mutahhir and
DanielMSchmidt
and removed request for
a team
[
|
[
|
xiehan
force-pushed
the
auto-upgrade-terraform
branch
from
78779ac
to
83cd622
Compare
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
|
I'm going to lock this pull request because it has been closed for at least 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow adapts https://github.com/hashicorp/terraform-cdk-action/blob/main/.github/workflows/upgrade-terraform.yml which is already successfully working in that repo. It runs once a week and will create a PR to upgrade to the newest patch version of Terraform if there is one. I didn't enable automerge for these PRs because as I discovered recently, the diffs don't function as reliable checks right now because they don't fail if there is an issue, so until we address that, I think we should probably manually inspect the diff output before merging these PRs.
FYI: As I was working on this, I realized our TF versions used in https://github.com/cdktf/cdktf-repository-manager/blob/main/.github/workflows/deploy-cdktf-stacks.yml and https://github.com/cdktf/cdktf-repository-manager/blob/main/.github/workflows/diff-cdktf-stacks.yml are out-of-sync which seems bad. Hopefully having this process automated will help prevent issues like this in the future.