feat: automate upgrading CDKTF #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiehan
requested review from
mutahhir and
ansgarm
and removed request for
a team
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
ansgarm
reviewed
Oct 4, 2023
.github/workflows/upgrade-cdktf.yml
Outdated
| id: latest_version | ||
| run: |- | ||
| CDKTF_VERSION=$(yarn info cdktf --json | jq -r '.data.version') | ||
| CDKTF_VERSION_SHORT=$(cut -d "." -f 2 <<< "$CDKTF_VERSION") |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
It's not just dropping the patch, what it's doing is grabbing the minor version number from the semver, e.g. if the version is 0.18.0 it results in 18, if the version is 1.6.0 it results in 6. I renamed the variable to CDKTF_VERSION_MINOR to be more self-documenting.
| This PR upgrades CDKTF to version `${{ needs.check_versions.outputs.latest_version }}` in `cdktf-repository-manager` (this repo). | ||
| Unfortunately, not everything can be automated, and the following steps need to be completed manually: | ||
|
|
||
| - [ ] Wait for #${{ needs.upgrade_repos.outputs.pr_id }} to be merged and for the deployment to succeed |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
1 task
[
|
[
|
[
|
[
|
|
I'm going to lock this pull request because it has been closed for at least 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow adapts scripts we're using elsewhere already like https://github.com/hashicorp/cdktf-aws-cdk/blob/main/.github/workflows/upgrade-cdktf.yml and https://github.com/hashicorp/terraform-cdk-action/blob/main/.github/workflows/upgrade-cdktf.yml to automatically create a PR to upgrade CDKTF when new (non-patch) versions come out. This variant creates two PRs:
Hopefully this will help prevent situations in the future like we had with this repo not updating its version of CDKTF for 6+ months.