fix: show triggering commit in provider PR titles #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiehan
requested review from
mutahhir and
DanielMSchmidt
and removed request for
a team
[
|
[
|
[
|
[
|
DanielMSchmidt
approved these changes
Jul 27, 2023
|
I'm going to lock this pull request because it has been closed for at least 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is relatively minor, but it's been bothering me for a while that our individual providers often end up with changelogs like:
Like, updated what? These messages aren't very useful.
These PR titles are generated when we push to main in this repo and the changes don't result in CDKTF, JSII, the underlying provider, Node, or Constructs being updated. I recognize that makes it difficult to articulate what the actual update was. (Most often it's just projen.) I figure at the very least as a fallback we can link back to the commit to main in this repo to show what triggered the update in the first place.
With this change, the changelogs will now look like: