fix: set GH_REPO env var in Go license script #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried running this script for the first time this morning and it failed. Looking into how this works in the Copywrite tool led me to https://github.com/cli/go-gh#go-library-for-the-github-cli which got me hoping that maybe all this is missing is this `GH_REPO` env var. Might be a long shot, though.
xiehan
requested review from
mutahhir and
DanielMSchmidt
and removed request for
a team
[
|
[
|
[
|
[
|
|
mostly a success, I guess: https://github.com/cdktf/cdktf-repository-manager/actions/runs/5474604055 The fix works, at least |
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
|
Going to merge since this has been successfully run in all repos: https://github.com/cdktf/cdktf-repository-manager/actions/runs/5475602525 |
xiehan
added a commit
that referenced
this pull request
Jul 12, 2023
While working on #206 today, I discovered lots of small housekeeping-type things that could be improved with our actions. The most consequential of these is: https://github.com/cdktf/cdktf-repository-manager/blob/59b0ad5e300f71491f8411d9e530202cd8af5b66/.github/workflows/upgrade-repositories.yml#L99-L100 This will allow us to retry calls that fail due to rate limits, which might help alleviate the issue where sometimes, the PRs don't get merged because the "automerge" label didn't get added. Worth a try, anyway!
|
I'm going to lock this pull request because it has been closed for at least 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried running this script for the first time this morning and it failed. Looking into how this works in the Copywrite tool led me to https://github.com/cli/go-gh#go-library-for-the-github-cli which got me hoping that maybe all this is missing is this
GH_REPOenv var. Might be a long shot, though.