-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to cdktf 0.17 and tsx #199
Conversation
02da131
to
2fc6b8b
Compare
[
|
[
|
[
|
[
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking this since the diff seems to have a lot of delete & creates. @DanielMSchmidt is this expected?
One thing that could be related is that we hard-code a very old version of the underlying GitHub provider here: cdktf-repository-manager/main.ts Lines 364 to 365 in 9fe1871
I suspect that may also need to be updated. I ran into this in #213 as well. |
5c43a3d
to
d0f63b4
Compare
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
@xiehan The problem is the removal of our feature flags leading to the old syntax (e.g. I'm going to pull the functionality we removed out into a function and set a fixed logical ID based on it for now, we can migrate the state once we have move blocks, but doing it by hand now across 3 stacks would be too cumbersome. |
Signed-off-by: team-tf-cdk <github-team-tf-cdk@hashicorp.com>
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
[
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! FYI, I also updated the TF workspaces to have the 1.4.6 Terraform version on the workspaces themselves.
[
|
[
|
[
|
[
|
I'm going to lock this pull request because it has been closed for at least 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue so we can investigate further. |
Please review the diffs
Closes hashicorp/terraform-cdk#2549