Skip to content

Commit

Permalink
fix: decrease max-parallel from 10 to 5 for provider upgrades (#228)
Browse files Browse the repository at this point in the history
We continue to run into Github errors with our user creating PRs and
setting labels. Hopefully this change improves that situation and fails
less.

Ideally, the Github CLI would honor rate limits and retry automatically,
but it doesn't support that at this time:
cli/cli#3292

<!--

Unless this is a very simple 1-line-of-code change, please create a new
issue describing the change you're proposing first, then link to it from
this PR.

Read more about our process in our contributing guide:
https://github.com/cdktf/.github/blob/main/CONTRIBUTING.md

-->

### Related issue

Fixes # <!-- INSERT ISSUE NUMBER -->

### Description

In plain English, describe your approach to addressing the issue linked
above. For example, if you made a particular design decision, let us
know why you chose this path instead of another solution.

### Checklist

- [ ] I have updated the PR title to match [CDKTF's style
guide](https://github.com/cdktf/.github/blob/main/CONTRIBUTING.md#pull-requests-1)
- [ ] I have run the linter on my code locally
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation if
applicable
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works if applicable
- [ ] New and existing unit tests pass locally with my changes

<!-- If this is still a work in progress, feel free to open a draft PR
until you're able to check off all the items on the list above -->
  • Loading branch information
ansgarm authored Oct 13, 2023
1 parent 1f927f4 commit 7d85635
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/upgrade-repositories.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
strategy:
fail-fast: false
matrix: ${{fromJSON(needs.build-provider-matrix.outputs.matrix)}}
max-parallel: 10
max-parallel: 5
steps:
- name: Checkout this repository
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
Expand Down

0 comments on commit 7d85635

Please sign in to comment.