Skip to content

Commit

Permalink
chore: Trigger update for maven credentials (and add comment) (#294)
Browse files Browse the repository at this point in the history
<!--

Unless this is a very simple 1-line-of-code change, please create a new
issue describing the change you're proposing first, then link to it from
this PR.

Read more about our process in our contributing guide:
https://github.com/cdktf/.github/blob/main/CONTRIBUTING.md

-->

### Description
Maven recently changed the credentials required for publishing:

<img width="848" alt="image"
src="https://github.com/cdktf/cdktf-repository-manager/assets/573531/d71a9f57-69ca-4334-bdb1-962dd3071ee1">

As a reminder for future reference, the way publishing works is that we
use publib through github actions within each prebuilt provider
repository. The github action uses maven username and password through
the repository secrets. The secrets there are written by
`cdktf-repository-manager` (this repo) through Terraform. The secrets
that are sent to the repository through Terraform are stored within an
HCP Terraform variable set.

While this PR only adds a comment to the secret, the true change
happened within HCP Terraform. This PR was necessary to trigger the
Terraform plan apply resulting in updating all Prebuilt provider
repositories.
  • Loading branch information
mutahhir authored Jun 24, 2024
1 parent a211e50 commit 6160473
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/secrets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ export class PublishingSecretSet extends Construct {
"nuget-api-key",
"twine-username",
"twine-password",
"maven-username",
"maven-password",
"maven-username", // Use the user token from https://hashicorp.oss.sonatype.org/#profile;User%20Token (saved in 1Password)
"maven-password", // Use the user token password (same as above)
"maven-gpg-private-key",
"maven-gpg-private-key-passphrase",
"maven-staging-profile-id",
Expand Down

0 comments on commit 6160473

Please sign in to comment.