Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect unprocessable packages #498

Merged
merged 15 commits into from
Nov 16, 2021
Merged

Conversation

iliapolo
Copy link
Contributor

Based on our experience from construct hub, adding a few surgical error handling:

Uninstallable Packages

Some packages cannot be installed. We've observed the following:

Corrupt Assembly

Some packages have a corrupt assembly. We've observed the following:

Unsupported Language

Added this detection here to further alleviate burden from callers.

});

test('throws corrupt assembly', async () => {
const docs = await Documentation.forPackage('@epilot/cdk-constructs@1.0.7');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would make sense to vend the packages in these tests as fixtures instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly. I don't think it makes that much of a difference since dependencies are still fetched from NPM.

The right thing to do here is to create a fixture project that simulates the scenario under test...but...for another time :)

@mergify mergify bot merged commit c2d83d5 into main Nov 16, 2021
@mergify mergify bot deleted the epolon/unprocessable-packages branch November 16, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants