-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detect unprocessable packages #498
Conversation
}); | ||
|
||
test('throws corrupt assembly', async () => { | ||
const docs = await Documentation.forPackage('@epilot/cdk-constructs@1.0.7'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would make sense to vend the packages in these tests as fixtures instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly. I don't think it makes that much of a difference since dependencies are still fetched from NPM.
The right thing to do here is to create a fixture project that simulates the scenario under test...but...for another time :)
Based on our experience from construct hub, adding a few surgical error handling:
Uninstallable Packages
Some packages cannot be installed. We've observed the following:
package.json
dependency. For example: https://github.com/markusl/cdk-codepipeline-bitbucket-build-result-reporter/blob/v0.0.7/package.json#L35.Corrupt Assembly
Some packages have a corrupt assembly. We've observed the following:
@epilot/cdk-constructs@1.0.7
@pahud/cdktf-aws-eks@0.0.14
Unsupported Language
Added this detection here to further alleviate burden from callers.