fix: don't emit examples larger than 500 lines #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `aws-quicksight` library would produce an example that is 30,000 lines. There is no real point to this and in fact blows up the size of the Python source file by quite a lot, so refuse to generate examples that are too large. In the future we may choose to do this eliding more intelligently (for example, by skipping optional properties and/or limiting recursion depth), but this is a multidimensional optimization problem that may not be so simple to solve as it seems at first. Most important thing is to stop the bleeding.
Open
2 tasks
kaizencc
approved these changes
Jun 14, 2023
rix0rrr
added a commit
to aws/aws-cdk
that referenced
this pull request
Jun 15, 2023
Bump the version of this package to obtain the following fix: cdklabs/cdk-generate-synthetic-examples#272
mergify bot
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Jun 15, 2023
Bump the version of this package to obtain the following fix: cdklabs/cdk-generate-synthetic-examples#272 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
aws-quicksightlibrary would produce an example that is 30,000 lines. There is no real point to this and in fact blows up the size of the Python source file by quite a lot, so refuse to generate examples that are too large.In the future we may choose to do this eliding more intelligently (for example, by skipping optional properties and/or limiting recursion depth), but this is a multidimensional optimization problem that may not be so simple to solve as it seems at first. Most important thing is to stop the bleeding.
Fixes #