chore: unit test for pipelineName
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our first unit test, to make it a habit to write one for every feature. Misc: - Some updates to README - Add "npm test synth" which outputs the template for inspection
sam-goodwin
approved these changes
Dec 13, 2018
| npx cdk -a ${cdk_app} synth | ||
| exit 0 | ||
| fi | ||
|
|
There was a problem hiding this comment.
Why? This file seems to do more than "run test"?
There was a problem hiding this comment.
Ideally we'll replace it with https://github.com/awslabs/aws-cdk/issues/300
There was a problem hiding this comment.
I'll rename this to something like cdk-integ.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our first unit test, to make it a habit to write
one for every feature.
Misc:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.