feat: classes for common secret types #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
requested changes
Mar 27, 2022
iliapolo
requested changes
Mar 27, 2022
|
Ah I forgot committing from the GitHub UI messes up all the DCO checks -- I'm just going to squash and force push all of these commits. |
Signed-off-by: Christopher Rybicki <rybickic@amazon.com> Co-authored-by: Eli Polonsky <epolon@amazon.com>
Chriscbr
force-pushed
the
rybickic/secret-classes
branch
from
d47898b to
2e268e8
Compare
Signed-off-by: Christopher Rybicki <rybickic@amazon.com>
iliapolo
approved these changes
Mar 29, 2022
iliapolo
pushed a commit
that referenced
this pull request
Apr 13, 2022
This PR adds custom classes for the following secret types: - service account token secrets - basic authentication secrets - tls secrets - ssh authentication secrets - docker config secrets Closes #344 Signed-off-by: Christopher Rybicki <rybickic@amazon.com> (cherry picked from commit 716fb13) # Conflicts: # docs/java.md # docs/python.md # docs/typescript.md
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
iliapolo
added a commit
that referenced
this pull request
Apr 13, 2022
This PR adds custom classes for the following secret types: - service account token secrets - basic authentication secrets - tls secrets - ssh authentication secrets - docker config secrets Closes #344 Signed-off-by: Christopher Rybicki <rybickic@amazon.com> (cherry picked from commit 716fb13) # Conflicts: # docs/java.md # docs/python.md # docs/typescript.md Co-authored-by: Christopher Rybicki <rybickic@amazon.com>
iliapolo
pushed a commit
that referenced
this pull request
Apr 13, 2022
This PR adds custom classes for the following secret types: - service account token secrets - basic authentication secrets - tls secrets - ssh authentication secrets - docker config secrets Closes #344 Signed-off-by: Christopher Rybicki <rybickic@amazon.com> (cherry picked from commit 716fb13) # Conflicts: # docs/java.md # docs/python.md # docs/typescript.md
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
iliapolo
added a commit
that referenced
this pull request
Apr 13, 2022
This PR adds custom classes for the following secret types: - service account token secrets - basic authentication secrets - tls secrets - ssh authentication secrets - docker config secrets Closes #344 Signed-off-by: Christopher Rybicki <rybickic@amazon.com> (cherry picked from commit 716fb13) # Conflicts: # docs/java.md # docs/python.md # docs/typescript.md Co-authored-by: Christopher Rybicki <rybickic@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds custom classes for the following secret types:
Closes #344
Signed-off-by: Christopher Rybicki rybickic@amazon.com