Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer ipython import #255

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

ericpre
Copy link
Contributor

@ericpre ericpre commented Jun 3, 2023

When ipython is installed, from box import Box takes 0.5s.

Before this PR:
image

With this PR:
image

Using python -X importtime -c "from box import Box" 2> hs.txt && tuna hs.txt

@ericpre ericpre changed the base branch from master to develop June 3, 2023 13:30
@cdgriffith
Copy link
Owner

Thanks for the great addition and show of speed improvement!

Not sure what's up with pypy packaging error, but possibly unrelated / timing of it.

@cdgriffith cdgriffith merged commit e82a416 into cdgriffith:develop Jun 15, 2023
@cdgriffith cdgriffith mentioned this pull request Jun 15, 2023
cdgriffith added a commit that referenced this pull request Aug 26, 2023
* Adding #255 defer ipython import for large import speed improvements (thanks to Eric Prestat)
* Adding testing for Python 3.12
* Fixing #253 merge_update box list merge types not populated to sub dictionaries (thanks to lei wang)
* Fixing #257 Two test failures due to arguments having incorrect types (thanks to Michał Górny)
* Fixing stub files to match latest code signatures
* Removing #251 support for circular references in lists (thanks to d00m514y3r)

---------

Co-authored-by: Eric Prestat <eric.prestat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants