Skip to content

Remove custom setup to enable cross-compilation #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2024
Merged

Conversation

georgefst
Copy link
Collaborator

@georgefst georgefst commented Apr 5, 2022

This is really just a placeholder. Until we have a new approach to doctests, this serves as a branch to point to for projects where I need to cross-compile pretty-simple. I'll periodically rebase it on master.

Closes #82.

For some reason selecting "latest" Cabal leads to 3.10, despite 3.12 (recommended for GHC 9.10) being available.
@georgefst
Copy link
Collaborator Author

georgefst commented Dec 7, 2024

@cdepillabout I've updated this so that the doctests run on CI, following the approach suggested by @Kleidukos in #82.

Would you consider merging this? I know it doesn't pass your criteria from #129 (comment), namely working with Stack and Nix, but the old approach is an unmaintained hack, and even the better long-term solution, i.e. setup hooks (alluded to in #129 (comment)), may not be supported by either of those for a long time either.

I've lost track of how many projects I've had to point to this branch, especially in the last few months as I've been doing a lot with the Wasm backend.

(Note to self: if we do merge this, add something to docs about installing the binaries, and if not then cherry-pick the first commit in to a new PR.)

@cdepillabout
Copy link
Owner

@georgefst This PR works for me.

Could you add a section at the bottom of the README describing how to run the doctests? (I'm guessing just doing cabal install --ignore-project doctest --flag cabal-doctest and then ~/.local/bin/cabal-doctest, or something like that?)

Other than that, this looks good to me. Feel free to merge it in and cut a release.

@georgefst georgefst merged commit f5ee266 into master Dec 8, 2024
2 checks passed
@georgefst georgefst deleted the cross-compile branch December 8, 2024 12:24
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 31, 2025
## 4.1.3.0

*   Remove custom setup. This makes cross-compiling `pretty-simple` a lot more
    straightforward. No functionality has been lost from the library, since the
    custom setup was only used for generating tests.
    [#107](cdepillabout/pretty-simple#107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-compilation broken by custom Setup.hs used for doctests
2 participants