-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Qubit out of Bounds Error #496
Conversation
@burgholzer You can already look over the changes. I will fix the Linter warnings tomorrow. |
@burgholzer I was apparently to quick, i will first fix the failing tests... and ping you then. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
=====================================
Coverage 90.4% 90.5%
=====================================
Files 86 86
Lines 9982 10028 +46
Branches 1696 1711 +15
=====================================
+ Hits 9027 9078 +51
+ Misses 955 950 -5
|
@burgholzer Now it should be done. If there pops up another clang tidy warning, I do not know how to fix it anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks really good.
I just have a few minor comments, which you will find inline.
I hope they are easy to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great 👍🏼
Description
When executing slightly larger circuits it could happen that the size, particularly the width, of the entangling did not suffice which caused and uncaught error. This PR resolves this problem by disregarding all qubits that do not fit in the entangling zone and leaving them for a later iteration.
Checklist: