Keep na arch alive 2 #474
Merged
Keep na arch alive 2 #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsschmid
force-pushed
the
keep-na-arch-alive-2
branch
from
e0930d5 to
ae480d6
Compare
lsschmid
added
python
lsschmid
force-pushed
the
keep-na-arch-alive-2
branch
from
e5ccaa7 to
ae480d6
Compare
|
I'm not sure. Clion tells me that mqt-core has a newer version (which is true). But when I commit the exter link to mqt-core, it modifies the .pre_commit. Not sure why, but for this PR it also doesn't really matter. |
The best thing to do in cases like these is to simply not commit the submodule change. |
burgholzer
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixed the problem that for the Hybridmapper, using the Python bindings it can happen that the architecture object is deleted by the garbage collector, loosing the reference for the mapper. Now it is kept alive using the keep_alive functionality of PyBind.
Checklist: