Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early termination #409

Merged
merged 9 commits into from
Jan 2, 2024
Merged

Early termination #409

merged 9 commits into from
Jan 2, 2024

Conversation

EliasLF
Copy link
Collaborator

@EliasLF EliasLF commented Jan 2, 2024

Description

Introducing some basic early termination strategies for non-tight heuristics (i.e. for fidelity-aware mapping) and adding those respective metrics also to the benchmark information.
Additionally, I slightly cleaned up the benchmarking code (adding missing stubs for pyqmap and splitting global benchmarking info from layer-specific benchmarking info)

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@EliasLF EliasLF added feature New feature or request c++ Anything related to C++ code code quality Anything related to code quality and code style. labels Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5bac1c8) 93.0% compared to head (025d3fa) 93.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #409   +/-   ##
=====================================
  Coverage   93.0%   93.0%           
=====================================
  Files         46      46           
  Lines       4895    4946   +51     
  Branches     849     852    +3     
=====================================
+ Hits        4555    4604   +49     
- Misses       340     342    +2     
Flag Coverage Δ
cpp 92.7% <97.2%> (+<0.1%) ⬆️
python 96.0% <100.0%> (+<0.1%) ⬆️
Files Coverage Δ
include/MappingResults.hpp 83.5% <100.0%> (+4.4%) ⬆️
include/configuration/Configuration.hpp 100.0% <ø> (ø)
src/DataLogger.cpp 90.3% <100.0%> (-0.5%) ⬇️
src/mqt/qmap/compile.py 97.2% <100.0%> (+<0.1%) ⬆️
src/heuristic/HeuristicMapper.cpp 94.1% <95.4%> (+<0.1%) ⬆️

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good! Could you maybe add an additional test or something like that so that the coverage CI does not complain?

@EliasLF
Copy link
Collaborator Author

EliasLF commented Jan 2, 2024

Thanks for the review! I just added further tests and will merge once the CI passes

@EliasLF EliasLF merged commit 6d17373 into cda-tum:main Jan 2, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code code quality Anything related to code quality and code style. feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants