-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Early termination #409
Early termination #409
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
=====================================
Coverage 93.0% 93.0%
=====================================
Files 46 46
Lines 4895 4946 +51
Branches 849 852 +3
=====================================
+ Hits 4555 4604 +49
- Misses 340 342 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here look good! Could you maybe add an additional test or something like that so that the coverage CI does not complain?
Thanks for the review! I just added further tests and will merge once the CI passes |
Description
Introducing some basic early termination strategies for non-tight heuristics (i.e. for fidelity-aware mapping) and adding those respective metrics also to the benchmark information.
Additionally, I slightly cleaned up the benchmarking code (adding missing stubs for pyqmap and splitting global benchmarking info from layer-specific benchmarking info)
Checklist: