Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in single-qubit gate adjusting in HeuristicMapper #408

Merged
merged 5 commits into from
Jan 2, 2024

Conversation

EliasLF
Copy link
Collaborator

@EliasLF EliasLF commented Jan 2, 2024

Description

The changed line previously treated qc::QuantumComputation::initialLayout as a mapping from virtual qubits to physical qubits instead of the other way around, which seems to be the canonical way everywhere else in the project. This leads to invalid qubit layouts in some edge cases (i.e. non-bijective mappings)

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@EliasLF EliasLF added bug Something isn't working c++ Anything related to C++ code labels Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec8d036) 93.0% compared to head (7d6ef95) 93.1%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #408     +/-   ##
=======================================
+ Coverage   93.0%   93.1%   +0.1%     
=======================================
  Files         46      46             
  Lines       4895    4895             
  Branches     849     849             
=======================================
+ Hits        4554    4559      +5     
+ Misses       341     336      -5     
Flag Coverage Δ
cpp 92.8% <100.0%> (+0.1%) ⬆️
python 96.0% <ø> (ø)
Files Coverage Δ
src/heuristic/HeuristicMapper.cpp 94.1% <100.0%> (+0.1%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍🏻 thanks for catching this!

@burgholzer burgholzer merged commit 5bac1c8 into cda-tum:main Jan 2, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c++ Anything related to C++ code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants