Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix definition issue for DCX gate in DD package #494

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

burgholzer
Copy link
Member

Description

Fixes #489.
The DCX gate (as well as the xx_minus_yy gate) had wrong gate matrix definitions in the underlying DD package within mqt-core.
These have now been fixed. A test has been added to check that the proper definition can be successfully verified.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Oct 26, 2024
@burgholzer burgholzer added c++ Anything related to C++ code fix Anything related to bugfixes labels Oct 26, 2024
@burgholzer burgholzer changed the title fix-dcx-endianness 🐛 Fix definition issue for DCX gate in DD package Oct 26, 2024
@burgholzer burgholzer enabled auto-merge (squash) October 26, 2024 14:51
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.3%. Comparing base (7f13175) to head (1a30d2f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #494   +/-   ##
=====================================
  Coverage   95.3%   95.3%           
=====================================
  Files         40      40           
  Lines       1835    1835           
  Branches     224     224           
=====================================
+ Hits        1749    1750    +1     
+ Misses        86      85    -1     
Flag Coverage Δ
cpp 95.8% <ø> (+<0.1%) ⬆️
python 93.7% <ø> (ø)

see 2 files with indirect coverage changes

@burgholzer burgholzer merged commit 2c7e7f1 into main Oct 26, 2024
28 checks passed
@burgholzer burgholzer deleted the fix-dcx-endianness branch October 26, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code fix Anything related to bugfixes
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Inconsistent Equivalence Result for DCX Validation
1 participant